Skip to content

Conversation

@fealho
Copy link
Member

@fealho fealho commented Sep 5, 2025

CU-86b6fugf3, Resolve #2661.

@sdv-team
Copy link
Contributor

sdv-team commented Sep 5, 2025

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 93.57798% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.06%. Comparing base (1705ced) to head (7706a5a).
⚠️ Report is 1 commits behind head on feature-branch-download-demo.

Files with missing lines Patch % Lines
sdv/datasets/demo.py 93.51% 7 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature-branch-download-demo    #2669      +/-   ##
================================================================
- Coverage                         98.13%   98.06%   -0.07%     
================================================================
  Files                                70       70              
  Lines                              7493     7556      +63     
================================================================
+ Hits                               7353     7410      +57     
- Misses                              140      146       +6     
Flag Coverage Δ
integration 75.95% <78.89%> (-0.38%) ⬇️
unit 96.75% <86.23%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fealho fealho force-pushed the issue-2661-download-demo-update branch from c5890fc to bc35d42 Compare September 10, 2025 16:54
@fealho fealho marked this pull request as ready for review September 10, 2025 16:55
@fealho fealho requested a review from a team as a code owner September 10, 2025 16:55
@fealho fealho requested review from frances-h and removed request for a team September 10, 2025 16:55
@fealho fealho requested review from amontanez24 and removed request for frances-h September 10, 2025 16:55
@fealho fealho force-pushed the issue-2661-download-demo-update branch from 1a7c849 to 94dd4dc Compare September 12, 2025 16:27
@fealho fealho force-pushed the issue-2661-download-demo-update branch from 94dd4dc to e6b0403 Compare September 12, 2025 16:28
@fealho fealho changed the base branch from main to feature-branch-download-demo September 12, 2025 16:59
@fealho fealho requested a review from gsheni September 12, 2025 16:59
@fealho fealho requested a review from amontanez24 September 25, 2025 15:04
@fealho fealho force-pushed the issue-2661-download-demo-update branch from 0286452 to 4984fc5 Compare September 25, 2025 17:29
@fealho fealho requested a review from frances-h September 25, 2025 18:37
@fealho fealho requested a review from frances-h September 25, 2025 19:26
@fealho fealho requested a review from amontanez24 September 25, 2025 20:43
@fealho fealho merged commit 47c09f4 into feature-branch-download-demo Sep 25, 2025
47 checks passed
@fealho fealho deleted the issue-2661-download-demo-update branch September 25, 2025 21:40
fealho added a commit that referenced this pull request Oct 6, 2025
Update the download_demo and get_available_demos functions (#2669)

Add test

Fix rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the download_demo and get_available_demos functions

6 participants