Skip to content

Feat/remove config logs #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Feat/remove config logs #923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eda7619
no sth/sequence config logs for non development
piotrek6641 Jul 27, 2023
87647d3
removed unnecessarly hidden logs
piotrek6641 Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/host/src/lib/host.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ import { SocketServer } from "./socket-server";
import { DataStream } from "scramjet";
import { optionsMiddleware } from "./middlewares/options";
import { corsMiddleware } from "./middlewares/cors";
import { ConfigService } from "@scramjet/sth-config";
import { ConfigService, development } from "@scramjet/sth-config";
import { isStartSequenceDTO, readJsonFile, defer, FileBuilder } from "@scramjet/utility";
import { inspect } from "util";
import { auditMiddleware, logger as auditMiddlewareLogger } from "./middlewares/audit";
Expand All @@ -63,6 +63,7 @@ const PARALLEL_SEQUENCE_STARTUP = 4;

type HostSizes = "xs" | "s" | "m" | "l" | "xl";
const GigaByte = 1024 << 20;
const isDevelopment = development();

/**
* Host provides functionality to manage Instances and Sequences.
Expand Down Expand Up @@ -207,7 +208,7 @@ export class Host implements IComponent {

prettyLog.pipe(process.stdout);

this.logger.info("config", this.config);
if (isDevelopment) this.logger.info("config", this.config);

this.config.host.id ||= this.getId();
this.logger.updateBaseLog({ id: this.config.host.id });
Expand Down Expand Up @@ -775,7 +776,7 @@ export class Host implements IComponent {
this.sequenceStore.set({ id, config, instances: [], name: sequenceName, location: "STH" });
}

this.logger.info("Sequence identified", config);
this.logger.trace(`Sequence identified: ${config.id}`);

// eslint-disable-next-line max-len
await this.cpmConnector?.sendSequenceInfo(id, SequenceMessageCode.SEQUENCE_CREATED, config as unknown as GetSequenceResponse);
Expand Down Expand Up @@ -971,7 +972,7 @@ export class Host implements IComponent {
const communicationHandler = new CommunicationHandler();
const id = payload.instanceId || IDProvider.generate();

this.logger.debug("CSIC start payload", payload);
if (isDevelopment) this.logger.debug("CSIC start payload", payload);

const csic = new CSIController(id, sequence, payload, communicationHandler, this.config, this.instanceProxy);

Expand Down