Feat/remove config logs #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alicja-gruzdz
left a comment
alicja-gruzdz
left a comment
There was a problem hiding this comment.
One place missed :) when the config is passed at Sequence startup:
https://github.com/scramjetorg/transform-hub/pull/923/files#diff-49139fa83ab4d9b3443fcffc2158a1f67af14baa9622bf060cd5c92c32a3343bR928
Contributor
|
Let's also check Manager's logs, because I see it is passed to the Manager as well: |
alicja-gruzdz
approved these changes
Aug 8, 2023
piotrek6641
force-pushed
the
feat/remove-config-logs
branch
from
0bddf65 to
f08f311
Compare
piotrek6641
force-pushed
the
feat/remove-config-logs
branch
from
f08f311 to
eda7619
Compare
patuwwy
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY:
#620
clickup:
https://app.clickup.com/t/24308805/VDM-1301
What: when starting sth logs with all the config info won't be shown unless in development mode, same for sequence info