Skip to content

Conversation

@saimn
Copy link
Contributor

@saimn saimn commented Jun 22, 2021

Small updates while using doctestplus as an example for sphinx-astropy.

@saimn saimn requested a review from pllim June 22, 2021 07:38
@bsipocz
Copy link
Member

bsipocz commented Jun 22, 2021

Please add a changelog entry as we used to note dropping of supported versions. Otherwise this is good to go.

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the build wheel label for?

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I get it now. LGTM and I agree with @bsipocz 's comment about change log.

@saimn
Copy link
Contributor Author

saimn commented Jun 22, 2021

Ok, done.

@saimn saimn merged commit 8802cc4 into scientific-python:main Jun 22, 2021
@saimn saimn deleted the setup-updates branch June 22, 2021 17:17
@bsipocz bsipocz added this to the 0.10.0 milestone Jul 1, 2021
eerovaher added a commit to eerovaher/pytest-astropy that referenced this pull request Sep 20, 2021
Because `astropy` is about to start using features introduced in
`pytest-doctestplus` 0.11.0, the minimum required version needs to be
updated. Furthermore, the minimum supported Python version for
`pytest-doctestplus` is 3.7 since scientific-python/pytest-doctestplus#159, which
means support for Python 3.6 must be dropped here too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants