Update minimum required pytest-doctestplus version #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `astropy` is about to start using features introduced in `pytest-doctestplus` 0.11.0, the minimum required version needs to be updated. Furthermore, the minimum supported Python version for `pytest-doctestplus` is 3.7 since scientific-python/pytest-doctestplus#159, which means support for Python 3.6 must be dropped here too.
pllim
approved these changes
Sep 20, 2021
Member
pllim
left a comment
pllim
left a comment
There was a problem hiding this comment.
LGTM but I'll give other maintainers a chance to look, just in case their packages still rely on Python 3.6 or something.
Contributor
|
Looks good, and 3.6 is very old now (and people could still use the current version). Thanks @eerovaher ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
astropyis about to start using features introduced inpytest-doctestplus0.11.0, the minimum required version needs to beupdated. Furthermore, the minimum supported Python version for
pytest-doctestplusis 3.7 since scientific-python/pytest-doctestplus#159, whichmeans support for Python 3.6 must be dropped here too.