Skip to content

bugfix: Check if tests namespace is enabled #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgodzik merged 2 commits into from
Dec 5, 2022
Merged

bugfix: Check if tests namespace is enabled #1245

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a35ad5
bugfix: Check if tests namespace is enabled
tgodzik Dec 2, 2022
b2cede7
Improve information about the issue in Theia
tgodzik Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
ProviderResult,
Hover,
TextDocument,
tests as vscodeTextExplorer,
} from "vscode";
import {
LanguageClient,
Expand Down Expand Up @@ -600,7 +601,10 @@ function launchMetals(
"Test Explorer"
);

const istTestManagerDisabled = getTestUI() === "Code Lenses";
// vscodeTextExplorer can be undefined e.g. for eclipse theia,
// see https://github.com/scalameta/metals-vscode/discussions/1244
const istTestManagerDisabled =
!vscodeTextExplorer || getTestUI() === "Code Lenses";
const testManager = createTestManager(client, istTestManagerDisabled);

const disableTestExplorer = workspace.onDidChangeConfiguration(() => {
Expand Down