bugfix: Check if tests namespace is enabled#1245
Merged
tgodzik merged 2 commits intoscalameta:mainfrom Dec 5, 2022
Merged
Conversation
Eclipse Theia does not support test explorer currently. Related to scalameta#1244
kpodsiad
reviewed
Dec 2, 2022
| ); | ||
|
|
||
| const istTestManagerDisabled = getTestUI() === "Code Lenses"; | ||
| const istTestManagerDisabled = !tests || getTestUI() === "Code Lenses"; |
Member
There was a problem hiding this comment.
I don't fully get it, how is it supposed to help with issue?
Contributor
Author
There was a problem hiding this comment.
Seems that the namespace is undefined when the code is used in Theia
kpodsiad
approved these changes
Dec 2, 2022
Member
kpodsiad
left a comment
kpodsiad
left a comment
There was a problem hiding this comment.
nitpick, it's worth to write what this is important
Co-authored-by: Kamil Podsiadło <[email protected]>
tgodzik
force-pushed
the
support-theia
branch
from
85a42a1 to
b2cede7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eclipse Theia does not support test explorer currently.
Related to #1244