Skip to content

Conversation

@marcelmamula
Copy link
Contributor

Fixes for ansible-lint that is updated as part of #1118

Changes

  • # noqa var-naming[no-role-prefix] added to all tasks setting other sap_install variables, because using .ansible-lint-ignore will show it as warnings, polluting log.
  • Replace all detect_ register variables with correct internal name __sap_install_media_detect_register_

Result

ansible-lint --version
ansible-lint 25.9.0 using ansible-core:2.19.2 ansible-compat:25.8.1 ruamel-yaml:0.18.14 ruamel-yaml-clib:0.2.12

ansible-lint roles/sap_install_media_detect/

# Before
Failed: 73 failure(s), 0 warning(s) in 22 files processed of 24 encountered.

# After
Passed: 0 failure(s), 0 warning(s) in 22 files processed of 24 encountered.

@marcelmamula marcelmamula self-assigned this Sep 26, 2025
Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelmamula marcelmamula merged commit 11a7af2 into sap-linuxlab:dev Sep 29, 2025
10 checks passed
@marcelmamula marcelmamula deleted the linting_media branch November 24, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants