Skip to content

Conversation

@marcelmamula
Copy link
Contributor

Changes

  • Update all linting workflows to use dedicated github action
  • Remove all roles specific .ansible-lint files and replace them with collection specific .ansible-lint-ignore where required.
  • Rename workflows to make names shorter and simpler

Tests

Workflow logs can be found in my source branch.
Ansible Lint - Collection https://github.com/marcelmamula/community.sap_install/actions/runs/18036038991
Ansible Lint - sap_install_media_detect https://github.com/marcelmamula/community.sap_install/actions/runs/18036046118

Disclaimer

This PR is not focused on solving errors as those will be solved separately in dedicated PRs for given roles!

Issues remaining:
sap_install_media_detect

  • roles/sap_install_media_detect/tasks/find_files_after_extraction.yml contains lot of registers with var-naming[no-role-prefix]
jinja[invalid]: Error rendering template: can only concatenate list (not "UndefinedMarker") to list
roles/sap_ha_pacemaker_cluster/tasks/pre_steps_nwas_cs_ers.yml:65:57 Task/Handler: SAP HA Pacemaker - (systemd) Combine instance services from all nodes

var-naming[no-role-prefix]: Variables names from within roles should use sap_hostagent_ as a prefix. (register: ssl_config_output)
roles/sap_hostagent/tasks/config_ssl.yml:28:13 Task/Handler: Create the server PSE, the server certificate therein, and the Certificate Signing Request (CSR)

var-naming[no-role-prefix]: Variables names from within roles should use sap_hostagent_ as a prefix. (register: ssl_config_output)
roles/sap_hostagent/tasks/config_ssl.yml:45:13 Task/Handler: Grant SAP Host Agent access to the server PSE

var-naming[no-role-prefix]: Variables names from within roles should use sap_hostagent_ as a prefix. (register: ssl_config_output)
roles/sap_hostagent/tasks/config_ssl.yml:77:13 Task/Handler: Verify the server certificate chain

var-naming[no-role-prefix]: Variables names from within roles should use sap_hostagent_ as a prefix. (register: ssl_config_output)
roles/sap_hostagent/tasks/config_ssl.yml:92:13 Task/Handler: Restart SAPHOSTAGENT

var-naming[no-role-prefix]: Variables names from within roles should use sap_hostagent_ as a prefix. (register: installagent)
roles/sap_hostagent/tasks/deploy_bundle.yml:11:13 Task/Handler: Install SAPHOSTAGENT

fqcn[action-core]: Use FQCN for builtin module actions (ansible.builtin.yum).
roles/sap_hostagent/tasks/deploy_rpm.yml:12:3 Use `ansible.builtin.dnf` or `ansible.legacy.dnf` instead.

fqcn[action-core]: Use FQCN for builtin module actions (ansible.builtin.yum).
roles/sap_hostagent/tasks/deploy_rpm.yml:19:3 Use `ansible.builtin.dnf` or `ansible.legacy.dnf` instead.

var-naming[no-role-prefix]: Variables names from within roles should use sap_hostagent_ as a prefix. (register: extractagent)
roles/sap_hostagent/tasks/deploy_sar.yml:16:13 Task/Handler: Extract the SAPHOSTAGENT archive using SAPCAR

var-naming[no-role-prefix]: Variables names from within roles should use sap_hostagent_ as a prefix. (register: installagent)
roles/sap_hostagent/tasks/deploy_sar.yml:25:13 Task/Handler: Install SAPHOSTAGENT

var-naming[no-role-prefix]: Variables names from within roles should use sap_hostagent_ as a prefix. (register: extractagent)
roles/sap_hostagent/tasks/deploy_sar_remote.yml:4:13 Task/Handler: Extract the SAPHOSTAGENT archive using SAPCAR

var-naming[no-role-prefix]: Variables names from within roles should use sap_hostagent_ as a prefix. (register: installagent)
roles/sap_hostagent/tasks/deploy_sar_remote.yml:13:13 Task/Handler: Install SAPHOSTAGENT

Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcelmamula marcelmamula merged commit 9b773dd into sap-linuxlab:dev Sep 30, 2025
19 checks passed
@marcelmamula marcelmamula deleted the linting branch November 24, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants