Skip to content

use specialized 2-dimensional .log() method in .matrix_on_subgroup() #38805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbraun merged 1 commit into from
Oct 26, 2024
Merged

use specialized 2-dimensional .log() method in .matrix_on_subgroup() #38805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/sage/schemes/elliptic_curves/hom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1118,10 +1118,8 @@ def matrix_on_subgroup(self, domain_gens, codomain_gens=None):
imP = self._eval(P)
imQ = self._eval(Q)

from sage.groups.additive_abelian.additive_abelian_wrapper import AdditiveAbelianGroupWrapper
H = AdditiveAbelianGroupWrapper(R.parent(), [R,S], [n,n])
vecP = H.discrete_log(imP)
vecQ = H.discrete_log(imQ)
vecP = imP.log([R, S])
vecQ = imQ.log([R, S])

from sage.matrix.constructor import matrix
from sage.rings.finite_rings.integer_mod_ring import Zmod
Expand Down