use specialized 2-dimensional .log() method in .matrix_on_subgroup() #38805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x_on_subgroup() for speed
|
Documentation preview for this PR (built with commit fc05e23; changes) is ready! 🎉 |
Contributor
|
There's a timeout in doctest that I can't replicate locally. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 17, 2024
sagemathgh-38805: use specialized 2-dimensional .log() method in .matrix_on_subgroup() This should be equivalent but faster (see sagemath#38347). ```sage sage: E = EllipticCurve(GF((2^77-33, 2)), [1,0]) ....: P, Q = E.gens() ....: pi = E.automorphisms()[-1] ....: %time pi.matrix_on_subgroup([P, Q]) ``` Sage 10.5.beta7: ``` CPU times: user 13.8 s, sys: 32.5 ms, total: 13.8 s ``` This branch: ``` CPU times: user 48.1 ms, sys: 64 µs, total: 48.2 ms ``` URL: sagemath#38805 Reported by: Lorenz Panny Reviewer(s): grhkm21
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 18, 2024
sagemathgh-38805: use specialized 2-dimensional .log() method in .matrix_on_subgroup() This should be equivalent but faster (see sagemath#38347). ```sage sage: E = EllipticCurve(GF((2^77-33, 2)), [1,0]) ....: P, Q = E.gens() ....: pi = E.automorphisms()[-1] ....: %time pi.matrix_on_subgroup([P, Q]) ``` Sage 10.5.beta7: ``` CPU times: user 13.8 s, sys: 32.5 ms, total: 13.8 s ``` This branch: ``` CPU times: user 48.1 ms, sys: 64 µs, total: 48.2 ms ``` URL: sagemath#38805 Reported by: Lorenz Panny Reviewer(s): grhkm21
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 20, 2024
sagemathgh-38805: use specialized 2-dimensional .log() method in .matrix_on_subgroup() This should be equivalent but faster (see sagemath#38347). ```sage sage: E = EllipticCurve(GF((2^77-33, 2)), [1,0]) ....: P, Q = E.gens() ....: pi = E.automorphisms()[-1] ....: %time pi.matrix_on_subgroup([P, Q]) ``` Sage 10.5.beta7: ``` CPU times: user 13.8 s, sys: 32.5 ms, total: 13.8 s ``` This branch: ``` CPU times: user 48.1 ms, sys: 64 µs, total: 48.2 ms ``` URL: sagemath#38805 Reported by: Lorenz Panny Reviewer(s): grhkm21
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 23, 2024
sagemathgh-38805: use specialized 2-dimensional .log() method in .matrix_on_subgroup() This should be equivalent but faster (see sagemath#38347). ```sage sage: E = EllipticCurve(GF((2^77-33, 2)), [1,0]) ....: P, Q = E.gens() ....: pi = E.automorphisms()[-1] ....: %time pi.matrix_on_subgroup([P, Q]) ``` Sage 10.5.beta7: ``` CPU times: user 13.8 s, sys: 32.5 ms, total: 13.8 s ``` This branch: ``` CPU times: user 48.1 ms, sys: 64 µs, total: 48.2 ms ``` URL: sagemath#38805 Reported by: Lorenz Panny Reviewer(s): grhkm21
yyyyx4
deleted the
public/use_specialized_2dim_log_in_matrix_on_subgroup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be equivalent but faster (see #38347).
Sage 10.5.beta7:
This branch: