support passing two base points to .log() for elliptic-curve points #38347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 544556d; changes) is ready! 🎉 |
GiacomoPope
approved these changes
Jul 12, 2024
Contributor
GiacomoPope
left a comment
GiacomoPope
left a comment
There was a problem hiding this comment.
This is great! Thank you, means I can stop hand-writing this function all the time myself haha.
GiacomoPope
reviewed
Jul 12, 2024
yyyyx4
force-pushed
the
public/elliptic_curve_logarithms_2dim
branch
from
070db92 to
eb6e4b3
Compare
Member
Author
|
Thanks! I applied your suggestions, added a new random test, and seem to have fixed the bugs that were caught by the random test. |
Contributor
|
Cool! Thanks for making the changes. |
yyyyx4
force-pushed
the
public/elliptic_curve_logarithms_2dim
branch
from
85ff4df to
1ec358a
Compare
yyyyx4
force-pushed
the
public/elliptic_curve_logarithms_2dim
branch
from
1ec358a to
b9dbbb5
Compare
Member
Author
|
@GiacomoPope I've now simplified this following #38359 and I think it should be ready to be reviewed/merged. |
GiacomoPope
approved these changes
Aug 2, 2024
Contributor
GiacomoPope
left a comment
GiacomoPope
left a comment
There was a problem hiding this comment.
comment about comment, but this looks great.
SageMath version 10.5.beta1, Release Date: 2024-08-03
Member
Author
|
The CI seems to be morally green. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 17, 2024
sagemathgh-38805: use specialized 2-dimensional .log() method in .matrix_on_subgroup() This should be equivalent but faster (see sagemath#38347). ```sage sage: E = EllipticCurve(GF((2^77-33, 2)), [1,0]) ....: P, Q = E.gens() ....: pi = E.automorphisms()[-1] ....: %time pi.matrix_on_subgroup([P, Q]) ``` Sage 10.5.beta7: ``` CPU times: user 13.8 s, sys: 32.5 ms, total: 13.8 s ``` This branch: ``` CPU times: user 48.1 ms, sys: 64 µs, total: 48.2 ms ``` URL: sagemath#38805 Reported by: Lorenz Panny Reviewer(s): grhkm21
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 18, 2024
sagemathgh-38805: use specialized 2-dimensional .log() method in .matrix_on_subgroup() This should be equivalent but faster (see sagemath#38347). ```sage sage: E = EllipticCurve(GF((2^77-33, 2)), [1,0]) ....: P, Q = E.gens() ....: pi = E.automorphisms()[-1] ....: %time pi.matrix_on_subgroup([P, Q]) ``` Sage 10.5.beta7: ``` CPU times: user 13.8 s, sys: 32.5 ms, total: 13.8 s ``` This branch: ``` CPU times: user 48.1 ms, sys: 64 µs, total: 48.2 ms ``` URL: sagemath#38805 Reported by: Lorenz Panny Reviewer(s): grhkm21
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 20, 2024
sagemathgh-38805: use specialized 2-dimensional .log() method in .matrix_on_subgroup() This should be equivalent but faster (see sagemath#38347). ```sage sage: E = EllipticCurve(GF((2^77-33, 2)), [1,0]) ....: P, Q = E.gens() ....: pi = E.automorphisms()[-1] ....: %time pi.matrix_on_subgroup([P, Q]) ``` Sage 10.5.beta7: ``` CPU times: user 13.8 s, sys: 32.5 ms, total: 13.8 s ``` This branch: ``` CPU times: user 48.1 ms, sys: 64 µs, total: 48.2 ms ``` URL: sagemath#38805 Reported by: Lorenz Panny Reviewer(s): grhkm21
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 23, 2024
sagemathgh-38805: use specialized 2-dimensional .log() method in .matrix_on_subgroup() This should be equivalent but faster (see sagemath#38347). ```sage sage: E = EllipticCurve(GF((2^77-33, 2)), [1,0]) ....: P, Q = E.gens() ....: pi = E.automorphisms()[-1] ....: %time pi.matrix_on_subgroup([P, Q]) ``` Sage 10.5.beta7: ``` CPU times: user 13.8 s, sys: 32.5 ms, total: 13.8 s ``` This branch: ``` CPU times: user 48.1 ms, sys: 64 µs, total: 48.2 ms ``` URL: sagemath#38805 Reported by: Lorenz Panny Reviewer(s): grhkm21
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 26, 2024
sagemathgh-38805: use specialized 2-dimensional .log() method in .matrix_on_subgroup() This should be equivalent but faster (see sagemath#38347). ```sage sage: E = EllipticCurve(GF((2^77-33, 2)), [1,0]) ....: P, Q = E.gens() ....: pi = E.automorphisms()[-1] ....: %time pi.matrix_on_subgroup([P, Q]) ``` Sage 10.5.beta7: ``` CPU times: user 13.8 s, sys: 32.5 ms, total: 13.8 s ``` This branch: ``` CPU times: user 48.1 ms, sys: 64 µs, total: 48.2 ms ``` URL: sagemath#38805 Reported by: Lorenz Panny Reviewer(s): grhkm21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The points on an elliptic curve over a finite field form a group of rank up to$2$ . In this patch we add support for passing two base points instead of just one to the
.log()method, which will decompose the given point as a linear combination of the given points. This functionality is already available via the.abelian_group()method of the elliptic curve, but the latter is much slower since it relies only on generic-group algorithms and does not exploit the Weil pairing:⌛ Dependencies
.log()method in finite fields #38350