-
-
Notifications
You must be signed in to change notification settings - Fork 725
Fix CI workflow errors #35005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI workflow errors #35005
Conversation
alexjbest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tobiasdiez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #35005 +/- ##
==========================================
Coverage ? 88.58%
==========================================
Files ? 2136
Lines ? 396141
Branches ? 0
==========================================
Hits ? 350933
Misses ? 45208
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@roed314 the diff here is not empty after merging in develop. What should happen with these changes? |
|
I updated the title and description. |
|
I tried to run the updated workflow from the main repo to check that the changes work as intended, but that doesn't work as it is in a different repo. Can you please activate github actions in your fork, make the |
|
I manually triggered it, and got the following error: I'm working on another issue, but I'll try to come back to this later today. |
|
Alright, I don't understand how to write these CI files, and I'm failing to figure out how to fix the problem. I'll create an issue to deal with this and close this PR (which was originally intended for fixing the checkmarks in CI). |
I've gotten several emails from github describing failed CI runs, and pointing to errors in the workflow files. This PR attempts to fix these errors.