add missing #long time markers to ell_number_field #34987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
ok, good to go |
Member
|
I think the "fixes #..." syntax only works in the pull request description. |
Member
Author
Indeed, thank you. |
JohnCremona
approved these changes
Feb 7, 2023
Member
|
I was just experimenting with the review process -- clearly this patch did not need a second review. |
Member
|
@vbraun we are considering to merge this since it's breaking the CI for everybody at SageDays. We'll discuss this with a few more people here but it seems that the CI should always pass on the develop branch. |
Member
|
@roed314 is preparing a separate PR to fix the linter errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34959.
It would be nice if this could be merged quickly as this (I think) is making CI tests fail on all PRs.