rustup to rustc 1.19.0-nightly (258ae6dd9 2017-06-15) #1833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
commented
Jun 16, 2017
| @@ -1,59 +0,0 @@ | |||
| error: I see you're using a LinkedList! Perhaps you meant some other data structure? | |||
Contributor
Author
There was a problem hiding this comment.
Ahh, This don't seem right.
messense
commented
Jun 16, 2017
| @@ -1,11 +1,3 @@ | |||
| error: Range::step_by(0) produces an infinite iterator. Consider using `std::iter::repeat()` instead | |||
Contributor
Author
There was a problem hiding this comment.
Not sure why this got removed.
Member
There was a problem hiding this comment.
@messense step_by is no longer a Range method due to rust-lang/rust#42310. These lines in clippy_lints/src/ranges.rs should be modified.
Contributor
Author
There was a problem hiding this comment.
So I guess it's better to rewrite it to lint on Iterator::step_by(0)?
Contributor
Author
There was a problem hiding this comment.
Actually, Iterator::step_by has assert!(step != 0);, it will panic if the given step is 0.
Member
Contributor
|
published as 0.0.140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by rust-lang/rust#42648