Skip to content

Conversation

@rnestler
Copy link
Member

Currently our travis pipeline is more or less useless, since we only build on nighlty which fails, but we ignore the result.

@rnestler rnestler requested a review from dbrgn June 16, 2017 11:09
Currently we only test on nightly and *ignore* the result!  Since it
should build witout problem on 1.15.1 onwards, we enable these.
@dbrgn
Copy link
Collaborator

dbrgn commented Jun 16, 2017

Hm, somehow clippy still doesn't work.

Btw, alternatively there's now a "cargo clippy" subcommand available, instead of conditional compilation.

@rnestler
Copy link
Member Author

Hm, somehow clippy still doesn't work.

I think it's just that it's currently broken for the latest nightly... Maybe we should use a star dependency? Or at least "^0.0" so we always have the latest clippy with the latest nightly which should work. See https://github.com/Manishearth/rust-clippy#usage

@dbrgn
Copy link
Collaborator

dbrgn commented Jun 16, 2017

Agree, let's use "^0.0".

Clippy only guarantees, that the latest clippy version will work with
the latest nightly build of Rust.  So we want to always use the latest
version.
@rnestler
Copy link
Member Author

@rnestler
Copy link
Member Author

@dbrgn OK like that?

Copy link
Collaborator

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also disable the IRC notifications?

Copy link
Collaborator

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, wrong crate.

@rnestler rnestler merged commit 6eede5e into master Jun 17, 2017
@rnestler rnestler deleted the fix_travis branch June 17, 2017 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants