Allow unused keys starting with cargo-#2761
Closed
pwoolcoc wants to merge 1 commit intorust-lang:masterfrom
Closed
Allow unused keys starting with cargo-#2761pwoolcoc wants to merge 1 commit intorust-lang:masterfrom
cargo-#2761pwoolcoc wants to merge 1 commit intorust-lang:masterfrom
Conversation
This change would make it so that cargo does not warn about "unused keys" for keys that start with `cargo-`. This could be useful for custom subcommands that want to be able to read settings from `Cargo.toml`.
|
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
pwoolcoc
changed the title
cargo-
Contributor
|
#2668 implements a similar approach |
Member
|
Thanks for the PR! Talking about this in the past, however, we've preferred the approach in #2668 to this. Would that suffice for your use case? |
Contributor
Author
|
Ah, sorry I hadn't seen that! That will be fine, sorry for the unnecessary PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change would make it so that cargo does not warn about "unused
keys" for keys that start with
cargo-. This could be useful for customsubcommands that want to be able to read settings from
Cargo.toml.