Don't warn about metadata keys in the manifest#2668
Conversation
|
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson |
|
☔ The latest upstream changes (presumably #2687) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
force-pushed
the
dont-warn-about-metadata
branch
from
b0712cb to
204d4a6
Compare
|
☔ The latest upstream changes (presumably #2743) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
force-pushed
the
dont-warn-about-metadata
branch
from
204d4a6 to
86bd8c0
Compare
|
ping r? @brson (there's actually a number of pings to go for https://github.com/rust-lang/cargo/pulls/alexcrichton, but I'm gonna elide them in lieu of this one and reduce the emails) |
|
☔ The latest upstream changes (presumably #2779) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+. Please add docs. |
External tools may want to store metadata in `Cargo.toml` that they read but Cargo itself doesn't read. For example `cargo-apk` uses this for pieces of configuration. Cargo unfortunately, however, warns about these keys as "unused keys in the manifest" This commit instead whitelists the `package.metadata` key to not warn about any data inside.
alexcrichton
force-pushed
the
dont-warn-about-metadata
branch
from
86bd8c0 to
ebd630d
Compare
|
@bors: r=brson |
|
📌 Commit ebd630d has been approved by |
Don't warn about `metadata` keys in the manifest External tools may want to store metadata in `Cargo.toml` that they read but Cargo itself doesn't read. For example `cargo-apk` uses this for pieces of configuration. Cargo unfortunately, however, warns about these keys as "unused keys in the manifest" This commit instead whitelists the `package.metadata` key to not warn about any data inside.
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
5 participants
External tools may want to store metadata in
Cargo.tomlthat they read butCargo itself doesn't read. For example
cargo-apkuses this for pieces ofconfiguration. Cargo unfortunately, however, warns about these keys as "unused
keys in the manifest"
This commit instead whitelists the
package.metadatakey to not warn about anydata inside.