This repository was archived by the owner on Aug 16, 2021. It is now read-only.
Deprecate failure #347
Merged
Deprecate failure #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluxon
added a commit
to gluxon/wireguard-uapi-rs
that referenced
this pull request
May 3, 2020
Since failure is now deprecated. See rust-lang-deprecated/failure#347
This was referenced May 3, 2020
|
I don't see any signs of deprecation on the crates.io page. It does not show README nor badges. |
This was referenced May 20, 2020
bors bot
added a commit
to rust-embedded/cargo-binutils
that referenced
this pull request
May 20, 2020
73: Move from failure to anyhow r=therealprof a=ZeroErrors ## Changes - Move from `failure` to `anyhow` for error handling ## Description As of `failure 0.1.8` it has been deprecated ([rust-lang-deprecated/failure#347](rust-lang-deprecated/failure#347)) in favor of using standard rust errors and it is recommended to do that via libraries such as [`anyhow`](https://github.com/dtolnay/anyhow) or [`thiserror`](https://github.com/dtolnay/thiserror). I chose to go with `anyhow` as its the simplest to convert over to and also since `cargo-binutils` isn't expected to be used as a library I see no need for more detailed error types (See: [dtolnay/anyhow#comparison-to-thiserror](https://github.com/dtolnay/anyhow#comparison-to-thiserror)). --- **Note:** `failure` isn't fully removed yet as the `rustc-cfg` dependency uses `failure`. I have opened a PR on that repo to hopefully get that changed (japaric/rustc-cfg#12) r? @therealprof Co-authored-by: Zero <[email protected]>
steveej
added a commit
to steveej-forks/openshift-cincinnati
that referenced
this pull request
Jun 4, 2020
Failure was [deprecated][0] and suggests anyhow+thiserror to replace itself in dependent projects. [0]: rust-lang-deprecated/failure#347
tarcieri
added a commit
to rustsec/advisory-db
that referenced
this pull request
Aug 27, 2020
This was referenced Mar 12, 2022
Closed
This was referenced May 11, 2022
This was referenced Jul 15, 2022
This was referenced Sep 10, 2022
This was referenced Nov 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://internals.rust-lang.org/t/failure-crate-maintenance/12087, I'm deprecating
failure. Since the current error-handling landscape in Rust wouldn't be what it is today withoutfailure, I'd like to thank @withoutboats for authoring and publishing this crate.