Move from failure to anyhow #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealprof
approved these changes
May 20, 2020
Contributor
therealprof
left a comment
therealprof
left a comment
There was a problem hiding this comment.
Excellent, I take it.
Any more changes in the queue? Seems like a good time to do a release otherwise. ;)
bors r+
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
failuretoanyhowfor error handlingDescription
As of
failure 0.1.8it has been deprecated (rust-lang-nursery/failure#347) in favor of using standard rust errors and it is recommended to do that via libraries such asanyhoworthiserror.I chose to go with
anyhowas its the simplest to convert over to and also sincecargo-binutilsisn't expected to be used as a library I see no need for more detailed error types (See: dtolnay/anyhow#comparison-to-thiserror).Note:
failureisn't fully removed yet as therustc-cfgdependency usesfailure. I have opened a PR on that repo to hopefully get that changed (japaric/rustc-cfg#12)r? @therealprof