fix: repair go-generate mock generation for pegomock v4#6292
Open
mateenali66 wants to merge 4 commits intorunatlantis:mainfrom
Open
fix: repair go-generate mock generation for pegomock v4#6292mateenali66 wants to merge 4 commits intorunatlantis:mainfrom
mateenali66 wants to merge 4 commits intorunatlantis:mainfrom
Conversation
Add explicit package import path to pegomock generate directives in server/controllers/events/ and server/controllers/web_templates/. Pegomock v4 uses go/packages to resolve interfaces, which fails when only the interface name is provided without a package path. This matches the pattern already used in server/events/ directives. Fixes runatlantis#4664 Signed-off-by: Mateen Anjum <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Repairs go generate mock generation for pegomock v4 by updating //go:generate directives in controller packages to include an explicit input package import path, matching the pattern already used in other working directives.
Changes:
- Updated pegomock
generatedirectives inserver/controllers/events/to passgithub.zerozr99.workers.dev/runatlantis/atlantis/server/controllers/eventsexplicitly. - Updated pegomock
generatedirective inserver/controllers/web_templates/to passgithub.zerozr99.workers.dev/runatlantis/atlantis/server/controllers/web_templatesexplicitly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/controllers/events/azuredevops_request_validator.go | Adds explicit package import path to pegomock generate directive to avoid interface resolution failure. |
| server/controllers/events/github_request_validator.go | Adds explicit package import path to pegomock generate directive to avoid interface resolution failure. |
| server/controllers/events/gitlab_request_parser_validator.go | Adds explicit package import path to pegomock generate directive to avoid interface resolution failure. |
| server/controllers/web_templates/web_templates.go | Adds explicit package import path to pegomock generate directive to avoid interface resolution failure. |
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pegomock generatedirectives inserver/controllers/events/andserver/controllers/web_templates/go/packagesto resolve interfaces, which fails when only the bare interface name is provided without a package pathserver/events/(e.g.,project_command_builder.go)Fixes #4664
Related upstream: petergtz/pegomock#127
Files changed
server/controllers/events/azuredevops_request_validator.go(reported in go-generate step is broken #4664)server/controllers/events/github_request_validator.goserver/controllers/events/gitlab_request_parser_validator.goserver/controllers/web_templates/web_templates.goTest plan
go generate ./server/controllers/events/...and verify mocks are regenerated without panicgo generate ./server/controllers/web_templates/...and verify mock is regenerated