Skip to content

fix: repair go-generate mock generation for pegomock v4#6292

Open
mateenali66 wants to merge 4 commits intorunatlantis:mainfrom
mateenali66:fix/go-generate-pegomock
Open

fix: repair go-generate mock generation for pegomock v4#6292
mateenali66 wants to merge 4 commits intorunatlantis:mainfrom
mateenali66:fix/go-generate-pegomock

Conversation

@mateenali66
Copy link

Summary

  • Add explicit package import path to pegomock generate directives in server/controllers/events/ and server/controllers/web_templates/
  • Pegomock v4 uses go/packages to resolve interfaces, which fails when only the bare interface name is provided without a package path
  • This matches the pattern already used by working directives in server/events/ (e.g., project_command_builder.go)

Fixes #4664

Related upstream: petergtz/pegomock#127

Files changed

  • server/controllers/events/azuredevops_request_validator.go (reported in go-generate step is broken #4664)
  • server/controllers/events/github_request_validator.go
  • server/controllers/events/gitlab_request_parser_validator.go
  • server/controllers/web_templates/web_templates.go

Test plan

  • Run go generate ./server/controllers/events/... and verify mocks are regenerated without panic
  • Run go generate ./server/controllers/web_templates/... and verify mock is regenerated
  • Verify existing tests still pass

Add explicit package import path to pegomock generate directives in
server/controllers/events/ and server/controllers/web_templates/.
Pegomock v4 uses go/packages to resolve interfaces, which fails when
only the interface name is provided without a package path. This matches
the pattern already used in server/events/ directives.

Fixes runatlantis#4664

Signed-off-by: Mateen Anjum <[email protected]>
Copilot AI review requested due to automatic review settings March 8, 2026 18:29
@dosubot dosubot bot added bug Something isn't working go Pull requests that update Go code labels Mar 8, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Repairs go generate mock generation for pegomock v4 by updating //go:generate directives in controller packages to include an explicit input package import path, matching the pattern already used in other working directives.

Changes:

  • Updated pegomock generate directives in server/controllers/events/ to pass github.com/runatlantis/atlantis/server/controllers/events explicitly.
  • Updated pegomock generate directive in server/controllers/web_templates/ to pass github.com/runatlantis/atlantis/server/controllers/web_templates explicitly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
server/controllers/events/azuredevops_request_validator.go Adds explicit package import path to pegomock generate directive to avoid interface resolution failure.
server/controllers/events/github_request_validator.go Adds explicit package import path to pegomock generate directive to avoid interface resolution failure.
server/controllers/events/gitlab_request_parser_validator.go Adds explicit package import path to pegomock generate directive to avoid interface resolution failure.
server/controllers/web_templates/web_templates.go Adds explicit package import path to pegomock generate directive to avoid interface resolution failure.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update Go code provider/azuredevops provider/github provider/gitlab

Projects

None yet

Development

Successfully merging this pull request may close these issues.

go-generate step is broken

2 participants