Open
Conversation
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
Owner
|
Hi @chenrui333, really appreciate this PR. Did you see that the checks failed? Looks like there are two different issues: 1/ 1.18 and 1.19 failed, because the Go version required in Pegomock is lower than the one in Ginkgo. I'm fine with bumping the Go version in Pegomock. I guess keeping only 2 older releases is fine. The other issue is in Go 1.22 and it's not as straight forward. Do you feel confident having a look at it and trying to resolve it? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seeing some CI run failure with go1.22, see https://github.com/chenrui333/pegomock/actions/runs/9524752621/job/26258033642
and bump ginkgo to latest release