Skip to content

Stabilize support for private read receipts#1319

Merged
zecakeh merged 2 commits intomainfrom
zecakeh/private-read-receipts
Oct 1, 2022
Merged

Stabilize support for private read receipts#1319
zecakeh merged 2 commits intomainfrom
zecakeh/private-read-receipts

Conversation

@zecakeh
Copy link
Copy Markdown
Contributor

@zecakeh zecakeh commented Oct 1, 2022

@zecakeh zecakeh requested a review from a team October 1, 2022 09:10
Copy link
Copy Markdown
Member

@ShadowJonathan ShadowJonathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zecakeh zecakeh force-pushed the zecakeh/private-read-receipts branch from ffc2c6f to cca9c31 Compare October 1, 2022 09:15
@zecakeh
Copy link
Copy Markdown
Contributor Author

zecakeh commented Oct 1, 2022

The force push was to solve a merge conflict in the changelog.

@zecakeh zecakeh enabled auto-merge (rebase) October 1, 2022 09:15
@ShadowJonathan
Copy link
Copy Markdown
Member

Still looks good.

Dont forget to do a final grep on the MSC number in the codebase, when you do these PRs, to be sure you removed any and all references to the MSC :)

@zecakeh zecakeh merged commit c141b7d into main Oct 1, 2022
@zecakeh zecakeh deleted the zecakeh/private-read-receipts branch October 1, 2022 09:34
@zecakeh
Copy link
Copy Markdown
Contributor Author

zecakeh commented Oct 1, 2022

Dont forget to do a final grep on the MSC number in the codebase, when you do these PRs, to be sure you removed any and all references to the MSC :)

That's usually what I do to make there PRs in the first place 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants