Merged
Conversation
Apparently it hates it when you do this.
clokep
reviewed
Aug 26, 2022
ghost
approved these changes
Sep 9, 2022
Member
Author
|
while we appreciate the support, approving PRs like this does not help them move faster :) |
ara4n
reviewed
Sep 12, 2022
ara4n
reviewed
Sep 12, 2022
ara4n
reviewed
Sep 12, 2022
ara4n
approved these changes
Sep 12, 2022
Member
ara4n
left a comment
ara4n
left a comment
There was a problem hiding this comment.
lgtm with minor quibbles. very pleasing to see what a simple diff it is in the end to the spec itself :)
Co-authored-by: Matthew Hodgson <[email protected]>
54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown (used as reference due to post-FCP edits): https://github.com/matrix-org/matrix-spec-proposals/blob/main/proposals/2285-hidden-read-receipts.md
MSC: matrix-org/matrix-spec-proposals#2285
Requires matrix-org/matrix-spec-proposals#3875
Reviewer: This is best reviewed commit-by-commit.
Preview: https://pr1216--matrix-spec-previews.netlify.app