Skip to content

Add support for rmw_connextdds #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emersonknapp merged 2 commits into from
Mar 11, 2021
Merged

Add support for rmw_connextdds #671

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b71e85
Replace rmw_connext_cpp with rmw_connextdds
asorbini Mar 5, 2021
32a9181
Restore exceptions for ros2/rmw_connext to ease transition to rticomm…
asorbini Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rosbag2_transport/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ function(create_tests_for_rmw_implementation)
# disable the following tests for connext
# due to slower discovery of nodes
set(SKIP_TEST "")
if(${rmw_implementation} MATCHES "(.*)connext(.*)")
Copy link
Member

@ivanpauno ivanpauno Mar 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could keep a (.*)connext(.*)_cpp filter here, which would skip the test for the old rmw_connext_cpp and rmw_connext_dynamic_cpp, but not for rmw_connextdds.

if(${rmw_implementation} MATCHES "rmw_connext(.*)_cpp")
set(SKIP_TEST "SKIP_TEST")
endif()

Expand Down