[jazzy] Update to version 2.1.3 of mcap and rosbag2_storage_mcap docs#2416
[jazzy] Update to version 2.1.3 of mcap and rosbag2_storage_mcap docs#2416Hpeox wants to merge 2 commits into
Conversation
Update the vendored MCAP tarball from releases/cpp/v1.3.1 to releases/cpp/v2.1.3 and remove the obsolete GCC 15 patch. Signed-off-by: Hpeox <hpx.peipei@gmail.com>
Keep the rosbag2_storage_mcap documentation in sync with the underlying MCAP documentation and writer semantics. Clarify that chunkSize is a soft ceiling rather than a hard limit. Signed-off-by: Hpeox <hpx.peipei@gmail.com>
|
@Hpeox Can you please clarify the reason for We generally avoid updating vendor packages in released ROS 2 distros unless the change is a narrowly scoped bug/security/compatibility fix, because vendor bumps can violate ABI stability or change recording/replay behavior or introduce new bugs. |
Thanks for the clarification. I understand the ABI / behavior stability concern for vendor bumps in released distros, and my intent here was to keep the change as small as possible. While looking into MCAP chunk behavior on Jazzy, I noticed that the vendored In practice, I was trying to rely on the newer upstream MCAP behavior / fixes in this area. Since Rolling had already moved to So I tried to keep the change as small as possible:
|
|
@Hpeox Am I understanding correctly that there is nothing broken? It is just label |
Yeah, mostly. What I noticed first was mainly that the However, this was not purely about newer features, and not just about the mismatch between the release notes and tagged source. There were also bug fixes between |
|
From one hand I would oppose to the movement to this updated for the mcap vendor package since we have a policy to not update vendor packages in the already released ROS distros and it bumps major version from Given the consideration above I would like to hear a second opinion in regards this |
|
We discussed this in the PMC meeting this week. I believe that increasing a major version in a released LTS without a strong reason is probably not the way to go. I don't see any evidence that there is a critical bug being fixed here. While If you absolutely need the newer mcap version in your Jazzy setup, I would suggest this is probably the right time to fork the package here. |
Description
This PR updates the vendored MCAP source in
mcap_vendoron thejazzybranch fromreleases/cpp/v1.3.1toreleases/cpp/v2.1.3.It also removes the obsolete GCC 15 patch from
mcap_vendor, since the corresponding include is already present upstream inreleases/cpp/v2.1.3.In addition, it updates the
rosbag2_storage_mcapdocumentation to keep it in sync with the MCAP documentation。This change follows the Rolling PR #2355 .
Is this user-facing behavior change?
No
Did you use Generative AI?
ChatGPT 5.4, helping draft PR descriptions and assisting with local build and test validation.
Additional Information
Local validation on ROS 2 Jazzy:
colcon build --packages-up-to rosbag2colcon test --packages-up-to rosbag2Additionally smoke-tested on local RealSense hardware by recording one camera's RGB and aligned depth topics to MCAP, verifying the result with
ros2 bag info, and successfully runningros2 bag playon the recorded bag.