Skip to content

Only fail on on relevant message topic in message count test #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Only fail on on relevant message topic in message count test #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions rosbag2_transport/test/rosbag2_transport/test_record_all_no_discovery.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

TEST_F(RecordIntegrationTestFixture, record_all_without_discovery_ignores_later_announced_topics)
{
auto topic = "/string_topic";
auto string_message = get_messages_strings()[0];
string_message->string_value = "Hello World";

Expand All @@ -32,12 +33,13 @@ TEST_F(RecordIntegrationTestFixture, record_all_without_discovery_ignores_later_
start_recording({true, true, {}, "rmw_format", 1ms});

std::this_thread::sleep_for(100ms);
auto publisher = publisher_node->create_publisher<test_msgs::msg::Strings>("/string_topic", 10);
auto publisher = publisher_node->create_publisher<test_msgs::msg::Strings>(topic, 10);
for (int i = 0; i < 5; ++i) {
std::this_thread::sleep_for(20ms);
publisher->publish(*string_message);
}
stop_recording();

ASSERT_THAT(writer_->get_messages(), SizeIs(0));
auto recorded_topics = writer_->get_topics();
EXPECT_EQ(0u, recorded_topics.count(topic));
}