Skip to content

Support 'ros2 action echo' #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2025
Merged

Support 'ros2 action echo' #978

merged 2 commits into from
Mar 14, 2025

Conversation

@Barry-Xu-2018
Copy link
Contributor

@Barry-Xu-2018 Barry-Xu-2018 commented Feb 19, 2025

@Barry-Xu-2018 Barry-Xu-2018 mentioned this pull request Feb 19, 2025
Open
@Barry-Xu-2018 Barry-Xu-2018 force-pushed the review/topic-implement-action-echo branch from 1d8b34e to 9684067 Compare March 5, 2025 09:46
@Barry-Xu-2018 Barry-Xu-2018 marked this pull request as ready for review March 13, 2025 01:22
@fujitatomoya fujitatomoya self-requested a review March 13, 2025 04:37
fujitatomoya
fujitatomoya requested changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, ltgm with several comments.

@Barry-Xu-2018
Copy link
Contributor Author

Barry-Xu-2018 commented Mar 14, 2025

Gist: https://gist.githubusercontent.com/Barry-Xu-2018/b7bf6ed7353257611b68a0995631452b/raw/a26a0ac152c7017c93c0770d3567430245f6a693/ros2_rolling.repos

BUILD args: --packages-above-and-dependencies ros2action
TEST args: --packages-above ros2action
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15384

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Mar 14, 2025

that is really weird... only windows passing 😅 there is an import error for type_extension, i am not sure why... i will retry after rebase.

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Mar 14, 2025

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Mar 14, 2025

rebase

✅ Branch has been successfully rebased

@fujitatomoya fujitatomoya force-pushed the review/topic-implement-action-echo branch from 8ce0d92 to 36129e6 Compare March 14, 2025 16:06
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Mar 14, 2025 •
edited
Loading

Pulls: #978
Gist: https://gist.githubusercontent.com/fujitatomoya/738238b8c1f92ef8eb88d5528fc9af70/raw/39ce61613c4516cdaf65500325cd4f45c66a76f1/ros2.repos
BUILD args: --packages-above-and-dependencies ros2action
TEST args: --packages-above ros2action
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15393

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit c24c7b5 into ros2:rolling Mar 14, 2025
2 checks passed
@kscottz kscottz mentioned this pull request May 5, 2025
Closed
4 tasks
@ros-discourse
Copy link

ros-discourse commented May 23, 2025

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-kilted-kaiju-release/43902/1

@fujitatomoya fujitatomoya mentioned this pull request Nov 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Barry-Xu-2018 @fujitatomoya @ros-discourse