Skip to content

Add new interfaces to enable intropsection for action #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2025
Merged

Add new interfaces to enable intropsection for action #1413

merged 2 commits into from
Mar 13, 2025

Conversation

@Barry-Xu-2018
Copy link
Contributor

@Barry-Xu-2018 Barry-Xu-2018 commented Feb 14, 2025 •
edited
Loading

This was referenced Feb 14, 2025
Open
Merged
Merged
@Barry-Xu-2018 Barry-Xu-2018 force-pushed the review/topic-action-configure-introspection branch from 5b5949e to 8559c0a Compare March 4, 2025 05:11
@Barry-Xu-2018 Barry-Xu-2018 marked this pull request as ready for review March 4, 2025 05:12
@fujitatomoya fujitatomoya self-assigned this Mar 11, 2025
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Mar 11, 2025

@Barry-Xu-2018 i will review this tomorrow.

fujitatomoya
fujitatomoya requested changes Mar 11, 2025
View reviewed changes
@Barry-Xu-2018
Address review comments
17c9e9b 
Signed-off-by: Barry Xu <[email protected]>
@Barry-Xu-2018
Copy link
Contributor Author

Barry-Xu-2018 commented Mar 12, 2025

Gist: https://gist.githubusercontent.com/Barry-Xu-2018/b7bf6ed7353257611b68a0995631452b/raw/b387cbc5288950964bb388b5cb4196b6ad82fcc9/ros2_rolling.repos

BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15347

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@Barry-Xu-2018
Copy link
Contributor Author

Barry-Xu-2018 commented Mar 12, 2025 •
edited by fujitatomoya
Loading

Windows is unstable.
It reported a failure test ros2bag.test.test_record_qos_profiles.test_record_qos_profiles

It should not be related to this change.
I re-run Windows CI again

  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Mar 12, 2025

windows CI disconnected, i just restarted the new one. and i agree, it should not be related to this PR.

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Mar 12, 2025

@Barry-Xu-2018 just in case, let's make sure windows CI is not affected by this PR.

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Mar 13, 2025

https://ci.ros2.org/job/ci_windows/23577/testReport/junit/ros2bag.test/test_record_qos_profiles/test_record_qos_profiles/ cannot be related to this PR, i will go ahead to merge this.

@fujitatomoya fujitatomoya merged commit 93c68bb into ros2:rolling Mar 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@fujitatomoya fujitatomoya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Barry-Xu-2018 @fujitatomoya