Skip to content

Conversation

@SidFaber
Copy link
Contributor

Only generate the error "Recompile with '-DENABLESECURITY=ON' error when not compiled with security and the environment variable ROS_SECURITY_STRATEGY="Enforce". Addresses #123 (comment) and #172 (comment).

Signed-off-by: Sid Faber [email protected]

Only generate "Recompile with '-DENABLESECURITY=ON' error when
ROS_SECURITY_STRATEGY="Enforce"

Signed-off-by: Sid Faber <[email protected]>
@SidFaber SidFaber changed the title Fix error message Address error message Apr 29, 2020
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@kyrofa kyrofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @SidFaber.

@ivanpauno
Copy link
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit 8e14104 into ros2:master Apr 29, 2020
@SidFaber SidFaber deleted the fix/suppress-warning branch April 30, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants