-
Notifications
You must be signed in to change notification settings - Fork 260
Feature: add logger_name property to subscription, publisher, service and client (backport #1471) #1476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… and client (#1471) Signed-off-by: Nadav Elkabets <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 4859c8a) # Conflicts: # rclpy/rclpy/client.py # rclpy/rclpy/impl/_rclpy_pybind11.pyi # rclpy/rclpy/publisher.py # rclpy/rclpy/service.py # rclpy/rclpy/subscription.py # rclpy/src/rclpy/client.cpp # rclpy/src/rclpy/client.hpp # rclpy/src/rclpy/service.cpp # rclpy/test/test_client.py # rclpy/test/test_service.py
|
Cherry-pick of 4859c8a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
fujitatomoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with green CI.
@ahcorde thanks for fixing up the conflicts.
|
Pulls: #1476 |
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Part of #1399.
According to the documentation of
rcl_node_get_logger_namethe value of the string may change, so I think it's best to fetch the most recent string when getting thelogger_nameproperty.This is an automatic backport of pull request #1471 done by Mergify.