Feature: add logger_name property to subscription, publisher, service and client #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nadav Elkabets <[email protected]>
nadavelkabets
changed the title
fujitatomoya
approved these changes
Jun 23, 2025
|
@ahcorde can you do the 2nd review for this? |
|
Pulls: #1471
|
nadavelkabets
commented
Jun 24, 2025
nadavelkabets
commented
Jun 24, 2025
Co-authored-by: Nadav Elkabets <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Nadav Elkabets <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]>
|
ahcorde
approved these changes
Jun 24, 2025
|
should we backport this PR to other distros ? |
This feature is part of the AsyncioExecutor PR. |
|
https://github.com/Mergifyio backport kilted jazzy humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
… and client (#1471) Signed-off-by: Nadav Elkabets <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 4859c8a)
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
… and client (#1471) Signed-off-by: Nadav Elkabets <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 4859c8a) # Conflicts: # rclpy/rclpy/client.py # rclpy/rclpy/impl/_rclpy_pybind11.pyi # rclpy/rclpy/publisher.py # rclpy/rclpy/service.py # rclpy/rclpy/subscription.py # rclpy/test/test_client.py
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
… and client (#1471) Signed-off-by: Nadav Elkabets <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 4859c8a) # Conflicts: # rclpy/rclpy/client.py # rclpy/rclpy/impl/_rclpy_pybind11.pyi # rclpy/rclpy/publisher.py # rclpy/rclpy/service.py # rclpy/rclpy/subscription.py # rclpy/src/rclpy/client.cpp # rclpy/src/rclpy/client.hpp # rclpy/src/rclpy/service.cpp # rclpy/test/test_client.py # rclpy/test/test_service.py
ahcorde
added a commit
that referenced
this pull request
Jun 25, 2025
… and client (#1471) (#1474) (cherry picked from commit 4859c8a) Signed-off-by: Nadav Elkabets <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Nadav Elkabets <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Jun 27, 2025
… and client (backport #1471) (#1475) Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: Nadav Elkabets <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
ahcorde
added a commit
that referenced
this pull request
Jun 30, 2025
… and client (backport #1471) (#1476) Signed-off-by: Alejandro Hernandez Cordero <[email protected]> Co-authored-by: Nadav Elkabets <[email protected]> Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
bjsowa
pushed a commit
to bjsowa/rclpy
that referenced
this pull request
Jul 9, 2025
… and client (ros2#1471) Signed-off-by: Nadav Elkabets <[email protected]> Signed-off-by: Alejandro Hernández Cordero <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Błażej Sowa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1399.
According to the documentation of
rcl_node_get_logger_namethe value of the string may change, so I think it's best to fetch the most recent string when getting thelogger_nameproperty.