Skip to content

Implement action generic client #2759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2025
Merged

Implement action generic client #2759

merged 3 commits into from
Mar 7, 2025

Conversation

@Barry-Xu-2018
Copy link
Collaborator

@Barry-Xu-2018 Barry-Xu-2018 commented Mar 3, 2025

Address ros-infrastructure/rep#405

Action GenericClient will be used in rosbag2 to support actions.

@Barry-Xu-2018 Barry-Xu-2018 mentioned this pull request Mar 3, 2025
Open
ahcorde
ahcorde requested changes Mar 3, 2025
View reviewed changes
@Barry-Xu-2018
Copy link
Collaborator Author

Barry-Xu-2018 commented Mar 4, 2025

@ahcorde

Thank you for your review.
I have addressed all your review comments at 9f366f0.

@ahcorde
Copy link
Contributor

ahcorde commented Mar 6, 2025

Pulls: #2759
Gist: https://gist.githubusercontent.com/ahcorde/222e1cc850a365d120f7b68ee1ba7ed4/raw/6509370844cf61fc69fe2ce57683a00cbedb620e/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp_action
TEST args: --packages-above rclcpp_action
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15295

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya self-requested a review March 6, 2025 17:34
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Mar 6, 2025

@ahcorde thanks for reviewing and running CI.

@Barry-Xu-2018 windows test build failed, can you take a look?

fujitatomoya
fujitatomoya approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one thing i would like to confirm.

@Barry-Xu-2018
Copy link
Collaborator Author

Barry-Xu-2018 commented Mar 7, 2025

windows test build failed, can you take a look?

I fixed it by 3f155e8.
However, there seems to be an issue with the CI system, and currently, I am unable to log in to rerun Window tests

@ahcorde
Copy link
Contributor

ahcorde commented Mar 7, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Mar 7, 2025

@ahcorde thanks for running CI. all your comments are addressed, could you approve?

@fujitatomoya fujitatomoya requested a review from ahcorde March 7, 2025 16:57
@ahcorde ahcorde merged commit 9db7659 into ros2:rolling Mar 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@Barry-Xu-2018 Barry-Xu-2018

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Barry-Xu-2018 @ahcorde @fujitatomoya