Add the missing visibility control macros

Signed-off-by: Barry Xu <[email protected]>

Author: Barry-Xu-2018

rclcpp_action/include/rclcpp_action/create_generic_client.hpp

@@ -37,6 +37,7 @@ namespace rclcpp_action
  * \param[in] options Options to pass to the underlying `rcl_action_client_t`.
  * \return newly created generic client.
  */
+RCLCPP_ACTION_PUBLIC
 typename GenericClient::SharedPtr
 create_generic_client(
   rclcpp::node_interfaces::NodeBaseInterface::SharedPtr node_base_interface,

rclcpp_action/include/rclcpp_action/generic_client.hpp

@@ -104,6 +104,7 @@ class GenericClient : public ClientBase
    * \param[in] action_typesupport_handle the action type support handle
    * \param[in] client_options Options to pass to the underlying `rcl_action::rcl_action_client_t`.
    */
+  RCLCPP_ACTION_PUBLIC
   GenericClient(
     rclcpp::node_interfaces::NodeBaseInterface::SharedPtr node_base,
     rclcpp::node_interfaces::NodeGraphInterface::SharedPtr node_graph,
@@ -139,6 +140,7 @@ class GenericClient : public ClientBase
    * \return A future that completes when the goal has been accepted or rejected.
    *   If the goal is rejected, then the result will be a `nullptr`.
    */
+  RCLCPP_ACTION_PUBLIC
   std::shared_future<typename GenericClientGoalHandle::SharedPtr>
   async_send_goal(
     const Goal goal,
@@ -153,6 +155,7 @@ class GenericClient : public ClientBase
    * \return A future that completes when the goal has been accepted or rejected.
    *   If the goal is rejected, then the result will be a `nullptr`.
    */
+  RCLCPP_ACTION_PUBLIC
   std::shared_future<typename GenericClientGoalHandle::SharedPtr>
   async_send_goal(
     const GoalRequest goal_request,
@@ -166,6 +169,7 @@ class GenericClient : public ClientBase
    * \param[in] result_callback Optional callback that is called when the result is received.
    * \return A future that is set to the goal result when the goal is finished.
    */
+  RCLCPP_ACTION_PUBLIC
   std::shared_future<WrappedResult>
   async_get_result(
     typename GenericClientGoalHandle::SharedPtr goal_handle,
@@ -184,6 +188,7 @@ class GenericClient : public ClientBase
    * <a href="https://github.com/ros2/rcl_interfaces/blob/master/action_msgs/srv/CancelGoal.srv">
    * action_msgs/CancelGoal.srv</a>.
    */
+  RCLCPP_ACTION_PUBLIC
   std::shared_future<typename CancelResponse::SharedPtr>
   async_cancel_goal(
     typename GenericClientGoalHandle::SharedPtr goal_handle,
@@ -199,6 +204,7 @@ class GenericClient : public ClientBase
    * <a href="https://github.com/ros2/rcl_interfaces/blob/master/action_msgs/srv/CancelGoal.srv">
    * action_msgs/CancelGoal.srv</a>.
    */
+  RCLCPP_ACTION_PUBLIC
   std::shared_future<typename CancelResponse::SharedPtr>
   async_cancel_all_goals(CancelCallback cancel_callback = nullptr);
 
@@ -213,13 +219,15 @@ class GenericClient : public ClientBase
    *
    * \param[in] goal_handle The goal were the callbacks shall be stopped
    */
+  RCLCPP_ACTION_PUBLIC
   void
   stop_callbacks(typename GenericClientGoalHandle::SharedPtr goal_handle);
 
   /// Stops the callbacks for the goal in a thread safe way
   /**
    * For further information see stop_callbacks(typename GenericGoalHandle::SharedPtr goal_handle)
    */
+  RCLCPP_ACTION_PUBLIC
   void
   stop_callbacks(const GoalUUID & goal_id);
 
@@ -234,11 +242,13 @@ class GenericClient : public ClientBase
    * <a href="https://github.com/ros2/rcl_interfaces/blob/master/action_msgs/srv/CancelGoal.srv">
    * action_msgs/CancelGoal.srv</a>.
    */
+  RCLCPP_ACTION_PUBLIC
   std::shared_future<typename CancelResponse::SharedPtr>
   async_cancel_goals_before(
     const rclcpp::Time & stamp,
     CancelCallback cancel_callback = nullptr);
 
+  RCLCPP_ACTION_PUBLIC
   virtual
   ~GenericClient();
 

rclcpp_action/include/rclcpp_action/generic_client_goal_handle.hpp

@@ -67,25 +67,32 @@ class GenericClientGoalHandle
         const void *)>;
   using ResultCallback = std::function<void (const WrappedResult & result)>;
 
-  virtual ~GenericClientGoalHandle();
+  RCLCPP_ACTION_PUBLIC
+  virtual
+  ~GenericClientGoalHandle();
 
   /// Get the unique ID for the goal.
+  RCLCPP_ACTION_PUBLIC
   const GoalUUID &
   get_goal_id() const;
 
   /// Get the time when the goal was accepted.
+  RCLCPP_ACTION_PUBLIC
   rclcpp::Time
   get_goal_stamp() const;
 
   /// Get the goal status code.
+  RCLCPP_ACTION_PUBLIC
   int8_t
   get_status();
 
   /// Check if an action client has subscribed to feedback for the goal.
+  RCLCPP_ACTION_PUBLIC
   bool
   is_feedback_aware();
 
   /// Check if an action client has requested the result for the goal.
+  RCLCPP_ACTION_PUBLIC
   bool
   is_result_aware();