-
Notifications
You must be signed in to change notification settings - Fork 481
Add new interfaces to enable intropsection for action #2743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new interfaces to enable intropsection for action #2743
Conversation
aa85eb3 to
b9db4bd
Compare
Signed-off-by: Barry Xu <[email protected]>
b9db4bd to
84ac6f5
Compare
|
Rebase was done. |
|
@Barry-Xu-2018 i will review this tomorrow. |
fujitatomoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost lgtm. a nitpick, and a couple of comments to confirm.
Signed-off-by: Barry Xu <[email protected]>
|
BUILD args: --packages-up-to rclcpp --packages-above-and-dependencies rclcpp |
Address ros-infrastructure/rep#405
Depend on ros2/rcl#1207