Skip to content

Conversation

@Barry-Xu-2018
Copy link
Collaborator

@Barry-Xu-2018 Barry-Xu-2018 commented Feb 14, 2025

@Barry-Xu-2018 Barry-Xu-2018 force-pushed the review/topic-action-configure-introspection branch from aa85eb3 to b9db4bd Compare March 4, 2025 05:03
@Barry-Xu-2018 Barry-Xu-2018 marked this pull request as ready for review March 4, 2025 05:04
@Barry-Xu-2018 Barry-Xu-2018 force-pushed the review/topic-action-configure-introspection branch from b9db4bd to 84ac6f5 Compare March 10, 2025 08:52
@Barry-Xu-2018
Copy link
Collaborator Author

Rebase was done.

@fujitatomoya fujitatomoya self-assigned this Mar 11, 2025
@fujitatomoya fujitatomoya self-requested a review March 11, 2025 05:49
@fujitatomoya
Copy link
Collaborator

@Barry-Xu-2018 i will review this tomorrow.

Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost lgtm. a nitpick, and a couple of comments to confirm.

Signed-off-by: Barry Xu <[email protected]>
@Barry-Xu-2018
Copy link
Collaborator Author

Gist: https://gist.githubusercontent.com/Barry-Xu-2018/b7bf6ed7353257611b68a0995631452b/raw/d1ba6e9db04288b0483ffdea2a9f9fd79be065d4/ros2_rolling.repos

BUILD args: --packages-up-to rclcpp --packages-above-and-dependencies rclcpp
TEST args: --packages-select rclcpp --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15346

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit 687057f into ros2:rolling Mar 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants