Skip to content

Update action cpp demos to support setting introspection #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2025
Merged

Update action cpp demos to support setting introspection #709

merged 2 commits into from
Mar 14, 2025

Conversation

@Barry-Xu-2018
Copy link
Contributor

@Barry-Xu-2018 Barry-Xu-2018 commented Feb 17, 2025 •
edited
Loading

@Barry-Xu-2018 Barry-Xu-2018 mentioned this pull request Feb 17, 2025
Open
ahcorde
ahcorde reviewed Feb 17, 2025
View reviewed changes
@Barry-Xu-2018 Barry-Xu-2018 marked this pull request as ready for review March 13, 2025 01:22
@fujitatomoya fujitatomoya self-requested a review March 13, 2025 04:37
fujitatomoya
fujitatomoya approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI.

@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Mar 13, 2025

Pulls: #709
Gist: https://gist.githubusercontent.com/fujitatomoya/87008c51fbec038d5d7388c5dbc58345/raw/b481446066faa968de0c3f55e62d525b6b0fe6ad/ros2.repos
BUILD args: --packages-above-and-dependencies action_tutorials_cpp
TEST args: --packages-above action_tutorials_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15379

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya requested a review from ahcorde March 14, 2025 04:10
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Mar 14, 2025

@ahcorde since you left the comments, can you check? and if you are okay with it, please go ahead to merge this.

@Barry-Xu-2018 Barry-Xu-2018 force-pushed the review/topic-action-introspection-cpp-demo branch from ffc65d6 to dc9823d Compare March 14, 2025 05:59
@Barry-Xu-2018
Copy link
Contributor Author

Barry-Xu-2018 commented Mar 14, 2025

Rebase was done.

@ahcorde
Copy link
Contributor

ahcorde commented Mar 14, 2025 •
edited
Loading

Pulls: #709
Gist: https://gist.githubusercontent.com/ahcorde/59e8b3545fa864dbe069f73585be9a87/raw/b481446066faa968de0c3f55e62d525b6b0fe6ad/ros2.repos
BUILD args: --packages-above-and-dependencies action_tutorials_cpp
TEST args: --packages-above action_tutorials_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15385

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit 805cdf1 into ros2:rolling Mar 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Barry-Xu-2018 @fujitatomoya @ahcorde