Revert "Qos configurability (#1408)" #1459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4c5986a. Signed-off-by: Ivan Santiago Paunovic <[email protected]>
jacobperron
approved these changes
Nov 16, 2020
clalancette
approved these changes
Nov 16, 2020
Member
Author
|
Merging without CI, as this is reverting last commit (no other commit was done in the middle). |
ivanpauno
added a commit
that referenced
this pull request
Nov 17, 2020
This reverts commit 27d1b11. Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1408, which introduced a build failure on Windows.
#1458 tried to fix it, but there are lots of Warnings too.