Skip to content

Fix windows build failure #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix windows build failure #1458

wants to merge 2 commits into from

Conversation

@ivanpauno
Copy link
Member

@ivanpauno ivanpauno commented Nov 16, 2020 •
edited
Loading

It seems that I ran CI in #1408 using master instead of the appropriate branch 🤦‍♂️ .

I think this fixes the Windows issues, if not I'm going to revert:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno
Fix windows
c08900f 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno ivanpauno added the bug Something isn't working label Nov 16, 2020
@ivanpauno ivanpauno self-assigned this Nov 16, 2020
@ivanpauno
not inline, visibility
b55392e 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Copy link
Member Author

ivanpauno commented Nov 16, 2020 •
edited
Loading

The macos failure was also introduced in #1408, but it's because this line here doesn't make sense (the pointer is null).

I'm not fixing that here to avoid rerunning CI, I can fix that simple error tomorrow.

@ivanpauno
Copy link
Member Author

ivanpauno commented Nov 16, 2020

Windows is building ok again.
The test failure is the same problem that macOS.

@clalancette
Copy link
Contributor

clalancette commented Nov 16, 2020

I'll point out that there are also 70 new build warnings on Windows, all in qos_overridding_options.hpp

@ivanpauno
Copy link
Member Author

ivanpauno commented Nov 16, 2020

Thanks @clalancette, I didn't see that.
I will revert #1408 and open a take 2 PR tomorrow.

@ivanpauno ivanpauno mentioned this pull request Nov 16, 2020
Merged
@ivanpauno ivanpauno closed this Nov 16, 2020
@clalancette clalancette deleted the ivanpauno/fix-windows branch January 15, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobperron jacobperron Awaiting requested review from jacobperron

@clalancette clalancette Awaiting requested review from clalancette

Assignees

@ivanpauno ivanpauno

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivanpauno @clalancette