Skip to content

Increasing test coverage of rclcpp_action #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brawner merged 10 commits into from
Apr 29, 2020
Merged

Increasing test coverage of rclcpp_action #1043

brawner merged 10 commits into from
Apr 29, 2020

Conversation

@brawner
Copy link
Contributor

@brawner brawner commented Mar 31, 2020

As part of the effort to bring the rclcpp packages up to Quality Level 1, this introduces many more tests of the rclcpp_action api. This brings the coverage from 76% to 83% of the src files and 94% of the include files (87% combined).

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Coverage Build Status

Signed-off-by: Stephen Brawner [email protected]

This was referenced Mar 31, 2020
Merged
Merged
ahcorde
ahcorde requested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question on construction_and_destruction_callback_group test

@brawner
Copy link
Contributor Author

brawner commented Apr 16, 2020

@ahcorde ping for review

ahcorde
ahcorde requested changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see this comment https://github.com/ros2/rclcpp/pull/1043/files#r410073208

@brawner brawner force-pushed the tests_rclcpp_action branch from 91dedaf to e823c67 Compare April 21, 2020 23:19
@brawner
Copy link
Contributor Author

brawner commented Apr 21, 2020

Rebased and addressed feedback @ahcorde

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

ahcorde
ahcorde approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just remove the duplicated line

@ahcorde
Copy link
Contributor

ahcorde commented Apr 22, 2020

In windows CI test_types is passing but in the result I see this error:

02:02:30 [MSBuild] [-ERROR-] Can't create fingerprints for some files:
02:02:30 [MSBuild] [-ERROR-] - 'C:/ci/ws/src/ros2/rclcpp/rclcpp_action/test/test_types.cpp', IO exception has been thrown: java.nio.file.NoSuchFileException: C:\ci\ws\src\ros2\rclcpp\rclcpp_action\test\test_types.cpp
02:02:30 [MSBuild] [-ERROR-] - 'C:/ci/ws/src/ros2/rclcpp/rclcpp_action/test/test_types.cpp', IO exception has been thrown: java.nio.file.NoSuchFileException: C:\ci\ws\src\ros2\rclcpp\rclcpp_action\test\test_types.cpp
02:02:30 [MSBuild] [-ERROR-] - 'C:/ci/ws/src/ros2/rclcpp/rclcpp_action/test/test_types.cpp', IO exception has been thrown: java.nio.file.NoSuchFileException: C:\ci\ws\src\ros2\rclcpp\rclcpp_action\test\test_types.cpp
02:02:30 [MSBuild] [-ERROR-] - 'C:/ci/ws/src/ros2/rclcpp/rclcpp_action/test/test_types.cpp', IO exception has been thrown: java.nio.file.NoSuchFileException: C:\ci\ws\src\ros2\rclcpp\rclcpp_action\test\test_types.cpp
02:02:30 [MSBuild] [-ERROR-] - 'C:/ci/ws/src/ros2/rclcpp/rclcpp_action/test/test_types.cpp', IO exception has been thrown: java.nio.file.NoSuchFileException: C:\ci\ws\src\ros2\rclcpp\rclcpp_action\test\test_types.cpp

@brawner
Copy link
Contributor Author

brawner commented Apr 22, 2020 •
edited
Loading

I'm not sure what the error that fingerprinting error relates to, but the ci_windows build was marked because I used the wrong unsigned type in the test_types.cpp file. I've fixed that, running the tests again.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Apr 27, 2020

  • macOS Build Status

brawner added 4 commits April 27, 2020 14:46
@brawner
Increasing test coverage of rclcpp_action
af0c99e 
Signed-off-by: Stephen Brawner <[email protected]>
@brawner
PR Fixup
d8007e1 
Signed-off-by: Stephen Brawner <[email protected]>
@brawner
PR Fixup
f22e870 
Signed-off-by: Stephen Brawner <[email protected]>
@brawner
PR Fixup
1550fae 
Signed-off-by: Stephen Brawner <[email protected]>
@brawner brawner force-pushed the tests_rclcpp_action branch from d3ac7f3 to 1550fae Compare April 27, 2020 21:46
@brawner
Copy link
Contributor Author

brawner commented Apr 27, 2020

Rebasing this branch and my ros2.repos file.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Apr 28, 2020

@brawner

brawner added 6 commits April 29, 2020 12:26
@brawner
Increasing test coverage of rclcpp_action
462b899 
Signed-off-by: Stephen Brawner <[email protected]>
@brawner
PR Fixup
0ce9da0 
Signed-off-by: Stephen Brawner <[email protected]>
@brawner
PR Fixup
61aea1a 
Signed-off-by: Stephen Brawner <[email protected]>
@brawner
PR Fixup
4d6c039 
Signed-off-by: Stephen Brawner <[email protected]>
@brawner
Merge branch 'tests_rclcpp_action' of github.com:brawner/rclcpp into …
8aae005 
…tests_rclcpp_action
@brawner
Fix warnings
5f9c5cb 
Signed-off-by: Stephen Brawner <[email protected]>
@brawner brawner force-pushed the tests_rclcpp_action branch from 24fd179 to 5f9c5cb Compare April 29, 2020 19:43
@brawner
Copy link
Contributor Author

brawner commented Apr 29, 2020 •
edited
Loading

Updating to fix deprecation warning.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@brawner brawner merged commit e632583 into ros2:master Apr 29, 2020
@brawner brawner deleted the tests_rclcpp_action branch April 29, 2020 21:26
@hidmic hidmic mentioned this pull request Jun 2, 2020
Merged
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Jul 7, 2020
@brawner
Increasing test coverage of rclcpp_action (ros2#1043)
1521181 
* Increasing test coverage of rclcpp_action

Signed-off-by: Stephen Brawner <[email protected]>

* PR Fixup

Signed-off-by: Stephen Brawner <[email protected]>

* PR Fixup

Signed-off-by: Stephen Brawner <[email protected]>

* PR Fixup

Signed-off-by: Stephen Brawner <[email protected]>

* Increasing test coverage of rclcpp_action

Signed-off-by: Stephen Brawner <[email protected]>

* PR Fixup

Signed-off-by: Stephen Brawner <[email protected]>

* PR Fixup

Signed-off-by: Stephen Brawner <[email protected]>

* PR Fixup

Signed-off-by: Stephen Brawner <[email protected]>

* Fix warnings

Signed-off-by: Stephen Brawner <[email protected]>
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
@EsipovPA
ros2#1043 Writer choices set to list (ros2#1044)
9291bcb 
* Set to list: writer_choices: record.py

Signed-off-by: EsipovPA <[email protected]>

* Set to list: storage_choices: reindex.py

Signed-off-by: EsipovPA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brawner @ahcorde