[foxy backport] Fix rcl_parse_yaml_file() error handling. (#776) #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should not fini its output argument, silently invalidating the given pointer. Signed-off-by: Michel Hidalgo <[email protected]>
Contributor
Author
Contributor
Author
|
Foxy CI up to
|
brawner
approved these changes
Sep 2, 2020
Contributor
brawner
left a comment
brawner
left a comment
There was a problem hiding this comment.
I guess this doesn't really change the intended API, so it should be fine
Contributor
|
Appropriate foxy ros2.repos is also necessary
|
Contributor
Author
|
Thanks ! |
Contributor
Author
|
@ros-pull-request-builder retest this please |
Contributor
Author
|
@jacobperron good to go (it's targeting Foxy)? |
jacobperron
approved these changes
Sep 22, 2020
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
LGTM
Don't worry about my approval for Foxy backports unless it's intentionally breaking ABI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should not fini its output argument, silently invalidating the given pointer.