Fix mem leaks in unit test from 776 #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Brawner <[email protected]>
Contributor
Author
|
Tests
|
Contributor
Author
|
With this PR both |
ahcorde
pushed a commit
that referenced
this pull request
Oct 8, 2020
Signed-off-by: Stephen Brawner <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Oct 9, 2020
Signed-off-by: Stephen Brawner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #776 removed the the call to
rcl_yaml_node_struct_finifromrcl_parse_yaml_filein the case of failure. Unfortunately the unit tests weren't updated and now exhibit some memory leaks. This PR addresses those leaks.Signed-off-by: Stephen Brawner [email protected]