Skip to content

Conversation

@brawner
Copy link
Contributor

@brawner brawner commented Dec 21, 2019

Adding dockerfile and install scripts to be able to eventually run builds and tests in a docker container for windows.

@brawner brawner changed the title Dockerfile to create a dev env on Windows and run ros2_batch scripts WIP Dockerfile to create a dev env on Windows and run ros2_batch scripts Dec 21, 2019
@cottsay cottsay added enhancement New feature or request in progress Actively being worked on (Kanban column) labels Dec 21, 2019
@brawner
Copy link
Contributor Author

brawner commented Dec 23, 2019

It looks like downloading OpenSSL might require regular link updates or hosting on a dedicated server. They bumped the build from "t" to "u". The Ros2 install instructions are nice because they link to the downloads page not the download itself.

Broken link
https://slproweb.com/download/Win64OpenSSL-1_0_2t.exe

Working link
https://slproweb.com/download/Win64OpenSSL-1_0_2u.exe

@brawner brawner force-pushed the windows-docker-resources branch 4 times, most recently from 78480a0 to 61b5af4 Compare December 24, 2019 00:23
@brawner
Copy link
Contributor Author

brawner commented Dec 24, 2019

Compiler checker issue has been resolved by cloning ci code into docker image instead of mounting a volume from the host computer.

Master branch of fastrtps does not compile under the latest VS tools (VS 16,24). A PR is pending. For now, I've uploaded two versions. One for VS 2017 and one for VS 2019. I've checked the 2017 version for build up to rclcpp for now.

@brawner brawner force-pushed the windows-docker-resources branch 20 times, most recently from 378b162 to a571109 Compare December 31, 2019 01:08
@brawner brawner force-pushed the windows-docker-resources branch from 893d37b to 07a31d3 Compare January 25, 2020 01:00
@brawner brawner force-pushed the windows-docker-resources branch from 07a31d3 to 27bbad8 Compare January 27, 2020 23:16
@brawner brawner changed the title WIP Dockerfile to create a dev env on Windows and run ros2_batch scripts Dockerfile to create a dev env on Windows and run ros2_batch scripts Jan 28, 2020
@brawner
Copy link
Contributor Author

brawner commented Jan 28, 2020

Removing WIP title, I think this is ready for review

@brawner brawner force-pushed the windows-docker-resources branch 3 times, most recently from 433b47e to 2474239 Compare January 28, 2020 23:18
@brawner
Copy link
Contributor Author

brawner commented Jan 28, 2020

After updating my desktop to 1909, and updating the EC2 instance to server core 1909, it appears that issues regarding building debug builds in a mounted directory can be resolved by running the docker container with "--isolation=process". Therefore, I'm no longer basing this PR on #375 and instead adding "--isolation=process" to docker run commands in #371

Example:
Build Status

@brawner brawner force-pushed the windows-docker-resources branch from 2474239 to f3e5f99 Compare January 29, 2020 20:01
@brawner brawner force-pushed the windows-docker-resources branch 3 times, most recently from 9d37cac to 4f2c7c0 Compare January 29, 2020 23:56
@brawner brawner force-pushed the windows-docker-resources branch from 4f2c7c0 to fd27094 Compare January 29, 2020 23:59
@nuclearsandwich nuclearsandwich changed the title Dockerfile to create a dev env on Windows and run ros2_batch scripts Dockerfile to create a dev env on Windows and run ros2_batch scr… Jan 31, 2020
@nuclearsandwich nuclearsandwich merged commit 80ebd14 into ros2:master Jan 31, 2020
nuclearsandwich added a commit that referenced this pull request Jan 31, 2020
PR #361 enabled parent credential passthrough unconditionally but it is only
needed on Windows (based on the fact that everything has been just
working on other platforms). This re-scopes that change so that only
Windows jobs are affected.
nuclearsandwich added a commit that referenced this pull request Jan 31, 2020
PR #361 enabled parent credential passthrough unconditionally but it is only
needed on Windows (based on the fact that everything has been just
working on other platforms). This re-scopes that change so that only
Windows jobs are affected.
nuclearsandwich added a commit that referenced this pull request Jan 31, 2020
* Only change credential passthrough on Windows.

PR #361 enabled parent credential passthrough unconditionally but it is only
needed on Windows (based on the fact that everything has been just
working on other platforms). This re-scopes that change so that only
Windows jobs are affected.

* Switch job templates to use windows_docker_resources

Co-authored-by: Steven! Ragnarök <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request in progress Actively being worked on (Kanban column)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants