-
Notifications
You must be signed in to change notification settings - Fork 33
Dockerfile to create a dev env on Windows and run ros2_batch scr… #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile to create a dev env on Windows and run ros2_batch scr… #361
Conversation
|
It looks like downloading OpenSSL might require regular link updates or hosting on a dedicated server. They bumped the build from "t" to "u". The Ros2 install instructions are nice because they link to the downloads page not the download itself. Broken link Working link |
78480a0 to
61b5af4
Compare
|
Compiler checker issue has been resolved by cloning ci code into docker image instead of mounting a volume from the host computer. Master branch of fastrtps does not compile under the latest VS tools (VS 16,24). A PR is pending. For now, I've uploaded two versions. One for VS 2017 and one for VS 2019. I've checked the 2017 version for build up to rclcpp for now. |
378b162 to
a571109
Compare
893d37b to
07a31d3
Compare
07a31d3 to
27bbad8
Compare
|
Removing WIP title, I think this is ready for review |
433b47e to
2474239
Compare
|
After updating my desktop to 1909, and updating the EC2 instance to server core 1909, it appears that issues regarding building debug builds in a mounted directory can be resolved by running the docker container with "--isolation=process". Therefore, I'm no longer basing this PR on #375 and instead adding "--isolation=process" to docker run commands in #371 |
2474239 to
f3e5f99
Compare
9d37cac to
4f2c7c0
Compare
4f2c7c0 to
fd27094
Compare
PR #361 enabled parent credential passthrough unconditionally but it is only needed on Windows (based on the fact that everything has been just working on other platforms). This re-scopes that change so that only Windows jobs are affected.
PR #361 enabled parent credential passthrough unconditionally but it is only needed on Windows (based on the fact that everything has been just working on other platforms). This re-scopes that change so that only Windows jobs are affected.
* Only change credential passthrough on Windows. PR #361 enabled parent credential passthrough unconditionally but it is only needed on Windows (based on the fact that everything has been just working on other platforms). This re-scopes that change so that only Windows jobs are affected. * Switch job templates to use windows_docker_resources Co-authored-by: Steven! Ragnarök <[email protected]>
Adding dockerfile and install scripts to be able to eventually run builds and tests in a docker container for windows.