Add windows-container to job templates using windows_docker_reso… #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brawner
force-pushed
the
ci_job_windows
branch
2 times, most recently
from
6072405 to
d00ed06
Compare
brawner
changed the title
brawner
force-pushed
the
ci_job_windows
branch
8 times, most recently
from
199add3 to
0d0d2dc
Compare
PR ros2#361 enabled parent credential passthrough unconditionally but it is only needed on Windows (based on the fact that everything has been just working on other platforms). This re-scopes that change so that only Windows jobs are affected.
brawner
force-pushed
the
ci_job_windows
branch
from
0d0d2dc to
8418a1c
Compare
nuclearsandwich
changed the title
nuclearsandwich
approved these changes
Jan 31, 2020
Member
nuclearsandwich
left a comment
nuclearsandwich
left a comment
There was a problem hiding this comment.
After discussion today we've updated this PR to live alongside our regular Windows builds. The diff on this branch adds new {test,}_ci_windows-container jobs and a ci_packaging_windows-container job.
As discussed it will also trigger a windows-container job from the launcher so we can compare the results between the contained and existing Windows jobs.
nuclearsandwich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds logic to the ci_job.xml.em and packaging_job.xml.em to make use of the windows docker resources. This is separated out from the other PR so that this is merged last and the other can be merged much sooner and manually tested.
Depends on: #361
New commit: b87a453