Skip to content

Add LXML for SROS2 #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjcarroll merged 5 commits into from
Feb 21, 2019
Merged

Add LXML for SROS2 #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
90a8ff6
Add LXML to Ubuntu dependencies
mjcarroll Feb 19, 2019
a9884ff
Add lxml to pip dependencies
mjcarroll Feb 19, 2019
7f0ae35
Add libxml2-dev
mjcarroll Feb 19, 2019
291caca
Add libxslt-dev
mjcarroll Feb 19, 2019
d619c39
Install LXML only on Windows and macOS
mjcarroll Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion linux_docker_resources/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ RUN apt-get update && apt-get install --no-install-recommends -y build-essential
RUN if test ${UBUNTU_DISTRO} != xenial; then apt-get update && apt-get install --no-install-recommends -y python3-lark-parser; fi

# Install build and test dependencies of ROS 2 packages.
RUN apt-get update && apt-get install --no-install-recommends -y clang-format cppcheck git libxml2-utils pydocstyle pyflakes python3-coverage python3-flake8 python3-mock python3-nose python3-pep8 python3-pyparsing python3-yaml uncrustify
RUN apt-get update && apt-get install --no-install-recommends -y clang-format cppcheck git libxml2-dev libxml2-utils libxslt-dev pydocstyle pyflakes python3-coverage python3-flake8 python3-lxml python3-mock python3-nose python3-pep8 python3-pyparsing python3-yaml uncrustify

# Install and self update pip/setuptools to the latest version.
RUN apt-get update && apt-get install --no-install-recommends -y python3-pip
Expand Down
5 changes: 5 additions & 0 deletions ros2_batch_job/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@
'pyyaml',
'vcstool',
]
if sys.platform in ('darwin', 'win32'):
pip_dependencies += [
'lxml'
]

colcon_packages = [
'colcon-core',
'colcon-defaults',
Expand Down