Add LXML for SROS2 #246
Merged
Add LXML for SROS2 #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CI (up to sros2)
|
libxml2 isn't present on ARM builds, so explicitly add it here.
Not present on aarch64.
It's installed via apt on Ubuntu platforms, and takes a long time to (unnecessarily) build on aarch64
Member
Author
|
mjcarroll
added
in review
8 tasks
jacobperron
approved these changes
Feb 21, 2019
Member
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
Looks okay.
I guess we should also update the build from source instructions accordingly.
Member
Author
|
Great, we're updating the docs for log4cxx, don't know why I didn't think about it here, but will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: ros2/sros2#72