Skip to content

Conversation

@clalancette
Copy link
Contributor

@clalancette clalancette commented May 22, 2020

This PR adds a link to REP-2006 (the Security Vulnerability Declaration) to the Quality Declaration for this repository.

FYI, this seems to touch every line because the script I used changed this from DOS line endings to Unix ones; I think we should keep it that way.

Connects to ros2/ros2#924.

@clalancette clalancette marked this pull request as draft May 22, 2020 19:26
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   25.43%   25.43%           
=======================================
  Files          26       26           
  Lines         798      798           
  Branches      185      185           
=======================================
  Hits          203      203           
  Misses        432      432           
  Partials      163      163           
Flag Coverage Δ
#unittests 25.43% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c245ac...b679e0e. Read the comment docs.

@clalancette clalancette marked this pull request as ready for review May 28, 2020 14:17
Copy link

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The REP is in.

Copy link
Member

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the newline format change or something? A little confused why all lines are marked as diff. Looks fine though

@clalancette
Copy link
Contributor Author

Did the newline format change or something? A little confused why all lines are marked as diff. Looks fine though

Yeah, it was all DOS line endings before, but the script I used to do all of this automatically converted them to Unix line endings. Given that the rest of this package all uses Unix line endings, I figured that was the way to go, so I left it.

@dabonnie dabonnie merged commit a222846 into ros-tooling:master Jun 1, 2020
ahcorde pushed a commit to ahcorde/libstatistics_collector that referenced this pull request Oct 27, 2020
ahcorde pushed a commit to ahcorde/libstatistics_collector that referenced this pull request Oct 27, 2020
Signed-off-by: Chris Lalancette <[email protected]>

Co-authored-by: Emerson Knapp <[email protected]>
Signed-off-by: ahcorde <[email protected]>
dabonnie pushed a commit that referenced this pull request Nov 5, 2020
* Add Security Vulnerability Policy pointing to REP-2006. (#24)

Signed-off-by: Chris Lalancette <[email protected]>

Co-authored-by: Emerson Knapp <[email protected]>
Signed-off-by: ahcorde <[email protected]>

* Updated QD to 3 (#30)

Signed-off-by: ahcorde <[email protected]>

* Updated QD Performance tests (#58)

Signed-off-by: ahcorde <[email protected]>

* updated QD links to foxy

Signed-off-by: ahcorde <[email protected]>

* fixed some links in the QD

Signed-off-by: ahcorde <[email protected]>

* Updated some QL in the QD

Signed-off-by: ahcorde <[email protected]>

* udpate QD

Signed-off-by: ahcorde <[email protected]>

Co-authored-by: Chris Lalancette <[email protected]>
Co-authored-by: Emerson Knapp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants