Skip to content

[Backport Foxy] Update QD #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 5, 2020
Merged

[Backport Foxy] Update QD #63

merged 7 commits into from
Nov 5, 2020

Conversation

@ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 27, 2020

No description provided.

@codecov
Copy link

codecov bot commented Oct 27, 2020 •
edited
Loading

Codecov Report

Merging #63 into foxy-devel will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           foxy-devel      #63      +/-   ##
==============================================
- Coverage       25.40%   24.75%   -0.65%     
==============================================
  Files              26       27       +1     
  Lines             807      820      +13     
  Branches          188      185       -3     
==============================================
- Hits              205      203       -2     
- Misses            435      454      +19     
+ Partials          167      163       -4
Flag Coverage Δ
unittests 24.75% <ø> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...istics_collector/test/collector/test_collector.cpp 45.09% <0.00%> (-1.06%) ⬇️
...rage_statistics/test_moving_average_statistics.cpp 58.41% <0.00%> (-0.41%) ⬇️
...s_collector/collector/metric_details_interface.hpp 100.00% <0.00%> (ø)
...ector/moving_average_statistics/moving_average.hpp 100.00% <0.00%> (ø)
...tics_collector/msg/dummy_message__type_support.cpp 0.00% <0.00%> (ø)
...ics_collector/msg/detail/dummy_message__struct.hpp 100.00% <0.00%> (ø)
...tics_collector/msg/dummy_message__type_support.cpp 0.00% <0.00%> (ø)
...llector/msg/detail/dummy_message__type_support.cpp 0.00% <0.00%> (ø)
...r/msg/dds_fastrtps/dummy_message__type_support.cpp
...cs_collector/msg/dummy_message__type_support_c.cpp
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d7db9...9c2f972. Read the comment docs.

@dabonnie
Copy link
Contributor

dabonnie commented Oct 27, 2020

Once the DCO passes this looks like it's ready (unless still in progress?).

@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 27, 2020

I cherry-picked all the commits I don't know why this is happening

chapulina
chapulina approved these changes Oct 27, 2020
View reviewed changes
Copy link

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the fixed foxy-devel links.

QUALITY_DECLARATION.md Outdated

The `rcl` package supports implementation of language specific ROS Client Libraries.

It is **Quality Level 3**, see its [Quality Declaration document](https://github.com/ros2/rcl/blob/foxy-devel/rcl/QUALITY_DECLARATION.md).
Copy link

@chapulina chapulina Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some (most?) of these branches should be foxy instead of foxy-devel.

chapulina
chapulina reviewed Oct 28, 2020
View reviewed changes
Copy link

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some dependencies can be updated

QUALITY_DECLARATION.md Outdated

The `std_msgs` package provides many basic message types.

It is **Quality Level 3**, see its [Quality Declaration document](https://github.com/ros2/common_interfaces/blob/foxy/std_msgs/QUALITY_DECLARATION.md).
Copy link

@chapulina chapulina Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is **Quality Level 3**, see its [Quality Declaration document](https://github.com/ros2/common_interfaces/blob/foxy/std_msgs/QUALITY_DECLARATION.md).
It is **Quality Level 2**, see its [Quality Declaration document](https://github.com/ros2/common_interfaces/blob/foxy/std_msgs/QUALITY_DECLARATION.md).

chapulina
chapulina reviewed Oct 30, 2020
View reviewed changes
Copy link

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this package can go straight to level 2, see the suggestions on ros2/rcl#843

@ahcorde
udpate QD
9c2f972 
Signed-off-by: ahcorde <[email protected]>
@chapulina
Copy link

chapulina commented Nov 5, 2020

@dabonnie , would you be able to merge this? Thanks!

@dabonnie dabonnie merged commit 8124b1a into ros-tooling:foxy-devel Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@chapulina chapulina chapulina approved these changes

@dabonnie dabonnie dabonnie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahcorde @dabonnie @chapulina @clalancette