Skip to content

Conversation

@CursedRock17
Copy link
Contributor

@CursedRock17 CursedRock17 commented Oct 29, 2024

Related to this pull request in geometry2 in which we deprecated the .h style headers in favor of .hpp.

Edit: I should mention this is meant to be a preemptive PR for if/when the related pull request gets approved. I'm also working on a backport so there won't be distribution issues

@clalancette clalancette changed the base branch from kinetic-devel to rolling October 31, 2024 11:36
@clalancette
Copy link
Contributor

@CursedRock17 I retargeted this at the rolling branch, and this now needs a rebase.

@CursedRock17 CursedRock17 force-pushed the deprecate_c_headers branch 4 times, most recently from 29ae614 to 22f3aa9 Compare November 2, 2024 08:53
@CursedRock17 CursedRock17 reopened this Nov 3, 2024
Signed-off-by: CursedRock17 <[email protected]>
Signed-off-by: CursedRock17 <[email protected]>
@CursedRock17
Copy link
Contributor Author

A bit wonkey but it seems to like the rebase.

@clalancette
Copy link
Contributor

Pulls: ros2/geometry2#720, ros2/rviz#1289, #98
Gist: https://gist.githubusercontent.com/clalancette/b83127091186f2489c09c4c787585861/raw/3c16fd56b4d645d09b9cadf800da79cbfd1acbaf/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14792

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Dec 18, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 288767f into ros-perception:rolling Dec 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants