Skip to content

Conversation

@pmusau17
Copy link
Contributor

@pmusau17 pmusau17 commented Jun 23, 2021

Fix for stereo_image_proc tests. Tested using rolling docker image. Passes all tests.
This PR is based on https://github.com/ros-perception/image_pipeline/pull/659/files by @jacobperron and will fix the timeout error in #669

jacobperron and others added 3 commits May 21, 2021 11:07
tf2_geometry_msgs.h was deprecated in ros2/geometry2#418
tf2_eigen.h was deprecated in ros2/geometry2#413

Signed-off-by: Jacob Perron <[email protected]>
Signed-off-by: Patrick Musau <[email protected]>
Signed-off-by: Patrick Musau <[email protected]>
@jacobperron
Copy link
Contributor

Cool, thanks for the fixes! I'll try to merge #659 separately, so I don't think we need to include that change in this PR.

I'm curious why we need to set approximate_sync to true, since we are using the exact same timestamp for inputs, e.g.

now = self.get_clock().now().to_msg()
self.left_image_and_info[0].header.stamp = now
self.left_image_and_info[1].header.stamp = now
self.right_image_and_info[0].header.stamp = now
self.right_image_and_info[1].header.stamp = now

Maybe it was use_system_default_qos that fixed the flake?

Also, are package.xml changes to image_publisher and image_view relevant?

Signed-off-by: Patrick Musau <[email protected]>
@pmusau17
Copy link
Contributor Author

For some reason it failed at first without those additions. I just retested it on galactic and rolling and it works. Also looks like it was use_system_default_qos that fixed it. I just updated the commit.

@jacobperron
Copy link
Contributor

Please revert a293252; I don't think it is compatible with Foxy or Galactic.

@JWhitleyWork JWhitleyWork merged commit f37816b into ros-perception:ros2 Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants