- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.6k
Add namespace for Rotation Shim primary controller for better dynamic parameters handling #5654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add namespace for Rotation Shim primary controller for better dynamic parameters handling #5654
Conversation
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
| Codecov Report✅ All modified and coverable lines are covered by tests. 
 ... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
 | 
Signed-off-by: mini-1235 <[email protected]>
| params_.primary_controller = node->declare_or_get_parameter<std::string>(plugin_name_ + | ||
| ".primary_controller.plugin"); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have a warning message if primary_controller is set, meaning that they didn't update the parsing. It would be good to explicitly mention this and provide a link to the migration guide entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
 params_.primary_controller = node->declare_or_get_parameter<std::string>(plugin_name_ +
    ".primary_controller.plugin");
requires it to be non empty in yaml. If it is empty, it will throw, I add a warning message there
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.