Skip to content

Conversation

@mini-1235
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4907
Primary OS tested on Ubuntu
Robotic platform tested on Tb4
Does this PR contain AI generated software? No
Was this PR description generated by AI software? Out of respect for maintainers, AI for human-to-human communications are banned

Description of contribution in a few bullet points

  • Added namespace for Rotation shim primary controller
  • Redesign dynamic patterns for Rotation shim
  • Refactor to better handle parameters

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.

@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
..._shim_controller/nav2_rotation_shim_controller.hpp 100.00% <ø> (ø)
...av2_rotation_shim_controller/parameter_handler.hpp 100.00% <100.00%> (ø)
...m_controller/src/nav2_rotation_shim_controller.cpp 92.42% <100.00%> (-0.55%) ⬇️
...rotation_shim_controller/src/parameter_handler.cpp 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: mini-1235 <[email protected]>
@mini-1235 mini-1235 changed the title Add namespace for Rotation Shim primary controller Add namespace for Rotation Shim primary controller for better dynamic parameters handling Oct 28, 2025
Comment on lines 50 to 51
params_.primary_controller = node->declare_or_get_parameter<std::string>(plugin_name_ +
".primary_controller.plugin");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a warning message if primary_controller is set, meaning that they didn't update the parsing. It would be good to explicitly mention this and provide a link to the migration guide entry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 params_.primary_controller = node->declare_or_get_parameter<std::string>(plugin_name_ +
    ".primary_controller.plugin");

requires it to be non empty in yaml. If it is empty, it will throw, I add a warning message there

Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
@mini-1235 mini-1235 mentioned this pull request Oct 31, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants